ViewVC logotype

Revision 2988

Jump to revision: Previous Next
Author: omarlaurino@gmail.com
Date: Fri Jun 5 17:32:11 2015 UTC (5 years, 4 months ago)
Changed paths: 17
Log Message:
  - modified pom.xml to take STIL from the CXC artifactory repo. You need to be inside the CXC HEAD network for it to work (or via VPN). When the service is opened to the public this limitation will disappear.
  - modified pom.xml to provide info regarding encoding and target Java VM (1.7).

  - the existing model factory was turned into a set of builders. Some trivial changes to VOTMapper and VOTableIO (and their tests) were required in order to make them work with the new infrastructure's API.
  - ModelMetadata interface was extracted from the Model interface so to make the "data" part independent from the "operations" part.
  - ModelTable now has a package private constructor that accepts a ModelTableBuilder builder. The ModelTableBuilder itself should probably be made a static nested class of ModelTable, except that I don't like the resulting API. We can do that at a later stage anyway.
  - clients can override the creation of a ModelTable class by providing its builder a ModelMetadata instance.
  - DACHS1.vot.xml now has spec2: utypes rather than spec:

The refactoring was tested by running all the tests and making sure they passed.
The new override functionality has a rather small test in VOTableIOTest::test_DACHS1 that simply checks you can access spec2:Target.Name. We will beef up the tests later.

 - I think my IDE also changed some imports. Sorry about that, I'll see if I can disable this.
 - Another non-functional change I made by mistake was reformatting the whole VOTableIOTest, rather than just the test I was working on. This adds noise to the diff.

Changed paths

Path Details
Directorytrunk/projects/dm/SpectralDM-2.0/code/speclib/ modified , props changed
Directorytrunk/projects/dm/SpectralDM-2.0/code/speclib/pom.xml modified , text changed
Directorytrunk/projects/dm/SpectralDM-2.0/code/speclib/src/main/java/cfa/vo/speclib/io/VOTMapper.java modified , text changed
Directorytrunk/projects/dm/SpectralDM-2.0/code/speclib/src/main/java/cfa/vo/speclib/io/VOTableIO.java modified , text changed
Directorytrunk/projects/dm/SpectralDM-2.0/code/speclib/src/main/java/cfa/vo/vomodel/AbstractModelBuilder.java added
Directorytrunk/projects/dm/SpectralDM-2.0/code/speclib/src/main/java/cfa/vo/vomodel/AbstractURLModelBuilder.java added
(Copied from trunk/projects/dm/SpectralDM-2.0/code/speclib/src/main/java/cfa/vo/vomodel/ModelFactory.java, r2980)
added , text changed
Directorytrunk/projects/dm/SpectralDM-2.0/code/speclib/src/main/java/cfa/vo/vomodel/Model.java modified , text changed
Directorytrunk/projects/dm/SpectralDM-2.0/code/speclib/src/main/java/cfa/vo/vomodel/ModelBuilder.java added
Directorytrunk/projects/dm/SpectralDM-2.0/code/speclib/src/main/java/cfa/vo/vomodel/ModelFactory.java deleted
Directorytrunk/projects/dm/SpectralDM-2.0/code/speclib/src/main/java/cfa/vo/vomodel/ModelMetadata.java added
Directorytrunk/projects/dm/SpectralDM-2.0/code/speclib/src/main/java/cfa/vo/vomodel/table/ModelTable.java modified , text changed
Directorytrunk/projects/dm/SpectralDM-2.0/code/speclib/src/main/java/cfa/vo/vomodel/table/ModelTableBuilder.java added
Directorytrunk/projects/dm/SpectralDM-2.0/code/speclib/src/test/java/cfa/vo/speclib/io/VOTMapperTest.java modified , text changed
Directorytrunk/projects/dm/SpectralDM-2.0/code/speclib/src/test/java/cfa/vo/speclib/io/VOTableIOTest.java modified , text changed
Directorytrunk/projects/dm/SpectralDM-2.0/code/speclib/src/test/java/cfa/vo/vomodel/table/ModelTableTest.java modified , text changed
Directorytrunk/projects/dm/SpectralDM-2.0/code/speclib/src/test/resources/test_data/baseline/DACHS1.vot.xml deleted


Name Value
google:author omarlaurino@gmail.com

ViewVC Help
Powered by ViewVC 1.1.26